-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update university-of-helsinki-faculty-of-theology.csl #1358
Conversation
(ref to 1301) I don't know how I should change the other cases in the `names`
|
You don't know what to do because you can't use a delimiter here? I would keep the suffix on |
That's a really odd initialization think, but unfortunately we don't have a style guide... |
@@ -279,34 +279,34 @@ | |||
<macro name="publisher"> | |||
<choose> | |||
<if type="bill graphic legal_case legislation motion_picture report song" match="any"> | |||
<group prefix=" "> | |||
<group suffix="; "> | |||
<group prefix=" " suffix=" " delimiter="; "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a semicolon in the suffix, since in the original there was one as part of the last group.
I think I mostly would appreciate if we can speak the changes through together. Okay? Let us maybe start with no. 3
|
that's all correct. |
For no. 3, it would be better to move the prefix on |
(Not that I would understand, why the editor is only added if there is an author, but let us leave it then, as it is.)
Okay, I updated the other case in a similar spirit. Please have a look. BTW I think the only case left for adjacent spaces is https://github.com/citation-style-language/styles/blob/master/spip-cite.csl#L67 . I am not sure what exactly this style is for. Is it okay as it is? Or should I delete the |
it's for an online publishing system. Leave this as is. |
Okay. Travis is happy here. Let me know what you think about the last one. Yes, I think this change here would close #1301 for now. 😆 |
Update university-of-helsinki-faculty-of-theology.csl
(ref to #1301)
I don't know how I should change the other cases in the
names