Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update university-of-helsinki-faculty-of-theology.csl #1358

Merged
merged 2 commits into from
Jan 24, 2015

Conversation

zuphilip
Copy link
Member

(ref to #1301)
I don't know how I should change the other cases in the names

(ref to 1301)
I don't know how I should change the other cases in the `names`
@zuphilip
Copy link
Member Author

 <if variable="author">
<names variable="editor">
<label form="verb-short" text-case="capitalize-first" suffix=" "/>
<name prefix=" " and="text" initialize-with=".."/>
</names>
</if>
 <if variable="author editor" match="any">
<names variable="translator" suffix=".">
<label form="verb-short" text-case="capitalize-first" suffix=" "/>
<name prefix=" " and="text" initialize="false" initialize-with=""/>
</names>
</if>
                <if variable="container-author">
                  <group>
                    <names variable="container-author">
                      <label form="verb-short" prefix=" " suffix=" " strip-periods="true"/>
                      <name and="text" prefix=" " delimiter=", " initialize-with=". "/>
                    </names>
                  </group>
                </if>

@rmzelle
Copy link
Member

rmzelle commented Jan 24, 2015

You don't know what to do because you can't use a delimiter here?

I would keep the suffix on <label/> and get rid of the prefix on <name/>. A name label will only print if there is a name, but a label term might be empty/non-defined.

@adam3smith
Copy link
Member

That's a really odd initialization think, but unfortunately we don't have a style guide...

@@ -279,34 +279,34 @@
<macro name="publisher">
<choose>
<if type="bill graphic legal_case legislation motion_picture report song" match="any">
<group prefix=" ">
<group suffix="; ">
<group prefix=" " suffix=" " delimiter="; ">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a semicolon in the suffix, since in the original there was one as part of the last group.

@zuphilip
Copy link
Member Author

I think I mostly would appreciate if we can speak the changes through together. Okay? Let us maybe start with no. 3

                <if variable="container-author">
                  <group>
                    <names variable="container-author">
                      <label form="verb-short" prefix=" " suffix=" " strip-periods="true"/>
                      <name and="text" prefix=" " delimiter=", " initialize-with=". "/>
                    </names>
                  </group>
                </if>
  • delete the prefix and let the suffix as it is
  • the group is not needed, thus I can delete it
  • the if is also not needed, right?
  • anything else?

@adam3smith
Copy link
Member

that's all correct.

@rmzelle
Copy link
Member

rmzelle commented Jan 24, 2015

For no. 3, it would be better to move the prefix on <label/> to <names/> (assuming it's needed).

(Not that I would understand, why the editor is only added if there is an author, but let us leave it then, as it is.)
@zuphilip
Copy link
Member Author

Okay, I updated the other case in a similar spirit. Please have a look.

BTW I think the only case left for adjacent spaces is https://github.com/citation-style-language/styles/blob/master/spip-cite.csl#L67 . I am not sure what exactly this style is for. Is it okay as it is? Or should I delete the suffix=" " on this line?

@adam3smith
Copy link
Member

it's for an online publishing system. Leave this as is.

@zuphilip
Copy link
Member Author

Okay. Travis is happy here. Let me know what you think about the last one. Yes, I think this change here would close #1301 for now. 😆

adam3smith added a commit that referenced this pull request Jan 24, 2015
Update university-of-helsinki-faculty-of-theology.csl
@adam3smith adam3smith merged commit 269c529 into citation-style-language:master Jan 24, 2015
@zuphilip zuphilip deleted the patch-2 branch January 24, 2015 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants