Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History - Process Instance and Variable Instance #32

Merged
merged 6 commits into from
Nov 28, 2021
Merged

History - Process Instance and Variable Instance #32

merged 6 commits into from
Nov 28, 2021

Conversation

sinhashubham95
Copy link
Contributor

No description provided.

@sinhashubham95
Copy link
Contributor Author

@liderman can you check this PR? I have added the implementations for history process and variable instance. Also made a few fixes in the external task.

Copy link
Contributor

@liderman liderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OK.
Later I will make a PR to replace "*[]string" with "[]string".
There is no point in using a pointer to slice.

@liderman liderman merged commit 5d3ddef into citilinkru:master Nov 28, 2021
@sinhashubham95
Copy link
Contributor Author

Yeah @liderman I thought of making that change as well, but that will result in a lot of changes. If you want we can connect once and can quickly get this done and a few other refactoring also I had in mind.

@liderman
Copy link
Contributor

@sinhashubham95 Ok. I was planning to release a major release "v3.0.0". Using go modules makes it safe.
I made a PR with the changes:
#33
If you want to make backward incompatible changes, you can submit a PR.
Let me know when you need to release "v3.0.0" and I'll tag it.

@sinhashubham95
Copy link
Contributor Author

@liderman I also had changes to use context in mind. Give me some time mostly by the next weekend or the one after that I will make all the changes.

@liderman
Copy link
Contributor

@sinhashubham95 Ok. No problem.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants