-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
History - Process Instance and Variable Instance #32
Conversation
@liderman can you check this PR? I have added the implementations for history process and variable instance. Also made a few fixes in the external task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All OK.
Later I will make a PR to replace "*[]string" with "[]string".
There is no point in using a pointer to slice.
Yeah @liderman I thought of making that change as well, but that will result in a lot of changes. If you want we can connect once and can quickly get this done and a few other refactoring also I had in mind. |
@sinhashubham95 Ok. I was planning to release a major release "v3.0.0". Using go modules makes it safe. |
@liderman I also had changes to use context in mind. Give me some time mostly by the next weekend or the one after that I will make all the changes. |
@sinhashubham95 Ok. No problem. |
No description provided.