AS-1317 Upgrade Halogen to v6 #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generic-rep is deprecated and merged into prelude with some module name changes.
`global` repo is deprecated and distributed to `js-uri` and `uri`. For our usage, `js-uri` is enough.
Following the upgrade guideline in the v6 changelog. See #subscriptions section for details.
Halogen.HTML.HTML is no longer needed to be specified in Halogen.Component type.
purescript 0.14 adds poly kind that enables unifying all proxy data types by one generic type Proxy so Halogen starts using that rather than SProxy.
Data.Map.Map no longer has Semigroup and Monoid instances which were considered biased by many people in the community. So since 2.0.0, the old behavior can be recovered by using the left biased Data.Map.union or Data.Map.SemigroupMap if the value has Semigroup instance. foldMap with Data.Map.singleton pattern no longer works.
The old Halogen.request and Halogen.tell are renamed to Halogen.mkRequest and Halogen.mkTell. New Halogen.request and Halogen.tell are specialized Halogen.query that save us some typing.
Action registry used to accept Nothing but no longer so. This applies to both Halogen.HTML.Events.* handlers and Halogen.HTML.slot. Use Halogen.HTML.slot_ if you don't need to register an Action to handle Output from child component.
boygao1992
requested review from
a team,
allgooda and
citizengabe
and removed request for
a team
|
Hmm CI is not happy about the new compiler [ SUCCESS ] Check if a prebuilt 0.14.1 binary is provided for linux (206ms)
[ SUCCESS ] Download the prebuilt PureScript binary (468ms)
[ FAILURE ] Verify the prebuilt binary works correctly
Error: Command failed: /home/circleci/ocelot/node_modules/purescript/purs.bin --version
/home/circleci/ocelot/node_modules/purescript/purs.bin: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /home/circleci/ocelot/node_modules/purescript/purs.bin)
/home/circleci/ocelot/node_modules/purescript/purs.bin: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /home/circleci/ocelot/node_modules/purescript/purs.bin)
at ChildProcess.exithandler (child_process.js:294:12)
at ChildProcess.emit (events.js:189:13)
at maybeClose (internal/child_process.js:970:16)
at Socket.stream.socket.on (internal/child_process.js:389:11)
at Socket.emit (events.js:189:13)
at Pipe._handle.close (net.js:597:12)Looks like something to do with this |
From previous experiment, ncurses is available in the CI environment so it's not the problem. After some researching, I think it's the version of glibc being too old (2.24 but purescript installer needs 2.27). I see people upgrade glibc directly in Dockerfile like ENV GLIBC_VERSION 2.25-r0 but we are using a docker image from CircleCI. Let me try overwriting it by adding to `environment` variables.
boygao1992
force-pushed
the
AS-1317/upgrade-halogen-v6
branch
from
276535a to
d76b94b
Compare
|
So #!/bin/bash -eo pipefail
sudo apt install libtinfo5 libncurses5-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
libncurses5-dev is already the newest version (6.0+20161126-1+deb9u2).
libtinfo5 is already the newest version (6.0+20161126-1+deb9u2).
libtinfo5 set to manually installed.
0 upgraded, 0 newly installed, 0 to remove and 3 not upgraded.
CircleCI received exit code 0The real problem should be the version of |
|
Ok now we get the /home/circleci/ocelot/node_modules/purescript/purs.bin: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directoryGoing to add a step to install |
|
CI fixed. |
davezuch
approved these changes
May 17, 2021
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Upgrade
purescriptto0.14.1and pin the new spago package set withhalogentov6.1.2.Fix a bunch of breaking changes from various repos
generic-repis deprecated and mostly moved intopreludewith some module name changesglobalsis deprecated and URI component encode/decode functions are moved tojs-uriordered-collectionsmoved left biasedSemigroupandMonoidinstances fromData.Map.Mapto a new data-typeData.Map.SemigroupMap(Safe.Coerce.coercecould save the wrapping and unwrapping of newtype now so not too inconvenient, but new instances useunionWith appendinstead ofunionthat requireSemigroupinstance on value too so it's not a drop-in replacement of the old instances)Where should the reviewer start?
One commit per breaking change.