Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1199): respect custom mailserver on startup #1209

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Aug 30, 2024

closes #1199.

@e17gpy I wen't for this implementation and will skip this part (as reported):

As the Citrus MailServerBuilder does not have functions to set the host manually, and the MailServer initialises the GreenMail server with a hardcoded host value of null, the Citrus MailServer will only bind to the loopback interface and not receive Mails from another interfaces.

I think for security reasons this is ok. whoever want's to bind to a specific interface should create a custom MailServer and use that - with the provided fix this is now possible. does this fit your needs?

@bbortt bbortt self-assigned this Aug 30, 2024
@bbortt bbortt added Type: Bug Prio: Medium State: Review If pull-request has been opened an is ready/in review labels Aug 30, 2024
@ghost
Copy link

ghost commented Sep 2, 2024

Hi, this should fit our needs. Thanks for implementing.

@bbortt bbortt merged commit 0ee0c56 into citrusframework:main Sep 2, 2024
1 check passed
@bbortt bbortt deleted the fix/#1199-mail-server branch September 2, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Medium State: Review If pull-request has been opened an is ready/in review Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citrus 4: MailServer only binds to loopback interface
1 participant