Skip to content

Commit

Permalink
PG17 regress test sanity: fix diffs in union_pushdown.
Browse files Browse the repository at this point in the history
Preserve the test error message by adjusting the query so that PG17
cannot pull it up to a join. Another instance of a subquery that can
be pulled up to a join with PG17 (#7745)
  • Loading branch information
colm-mchugh committed Nov 22, 2024
1 parent e108bb8 commit 3f10347
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/test/regress/expected/union_pushdown.out
Original file line number Diff line number Diff line change
Expand Up @@ -1409,7 +1409,7 @@ $$);

-- we hit https://github.com/citusdata/citus/blob/f00c63c33daf3d16f06462626ca14732b141ae7a/src/backend/distributed/planner/relation_restriction_equivalence.c#L235-L242
SELECT public.explain_has_distributed_subplan($$
EXPLAIN SELECT * FROM users_table_part u1 WHERE (value_1, user_id) IN
EXPLAIN SELECT * FROM users_table_part u1 WHERE (value_1 + random(), user_id) IN
(
SELECT u1.user_id, user_id FROM users_table_part
UNION
Expand Down
2 changes: 1 addition & 1 deletion src/test/regress/sql/union_pushdown.sql
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,7 @@ $$);

-- we hit https://github.com/citusdata/citus/blob/f00c63c33daf3d16f06462626ca14732b141ae7a/src/backend/distributed/planner/relation_restriction_equivalence.c#L235-L242
SELECT public.explain_has_distributed_subplan($$
EXPLAIN SELECT * FROM users_table_part u1 WHERE (value_1, user_id) IN
EXPLAIN SELECT * FROM users_table_part u1 WHERE (value_1 + random(), user_id) IN
(
SELECT u1.user_id, user_id FROM users_table_part
UNION
Expand Down

0 comments on commit 3f10347

Please sign in to comment.