Commits on Oct 6, 2022

1. Remove dependency on placement caches from DROP …

   When dropping objects, citus_drop_trigger should not depend on the
   validity of the caches for placements as it causes error messages from
   time to time. With this commit we remove the depencency on the validity
   on caches for shard placements.
   
   However, citus_drop_trigger still depends on WorkerNodeCache in 3
   different codepaths listed below:
   
   - master_remove_distributed_table_metadata_from_workers
    -> MasterRemoveDistributedTableMetadataFromWorkers
     -> SendCommandToWorkersWithMetadata
      -> SendCommandToMetadataWorkersParams
       -> TargetWorkerSetNodeList
        -> ActivePrimaryNonCoordinatorNodeList
         -> FilterActiveNodeListFunc
          -> GetWorkerNodeHash
   
   - citus_drop_all_shards
    -> DropShards
     -> DropTaskList
      -> ShardPlacementListIncludingOrphanedPlacementsViaCatalog
       -> LookupNodeForGroup
        -> PrepareWorkerNodeCache
   
   - master_remove_partition_metadata
    -> DeleteColocationGroupIfNoTablesBelong
     -> DeleteColocationGroup
      -> SyncDeleteColocationGroupToNodes
       -> SendCommandToWorkersWithMetadataViaSuperUser
        -> SendCommandToMetadataWorkersParams
         -> TargetWorkerSetNodeList
          -> ActivePrimaryNonCoordinatorNodeList
           -> FilterActiveNodeListFunc
            -> GetWorkerNodeHash

   

   hanefi committed Oct 6, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for e8d698d
   • Browse repository at this point

   Copy the full SHA

   e8d698d View commit details

   Browse the repository at this point in the history