Fix running PG upgrade tests with run_test.py #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6829 +/- ##
==========================================
- Coverage 93.27% 92.26% -1.01%
==========================================
Files 269 269
Lines 57448 57447 -1
==========================================
- Hits 53584 53003 -581
- Misses 3864 4444 +580 |
JelteF
force-pushed
the
run-test-pg-upgrade-fix
branch
from
6eccdbd to
1b1818c
Compare
JelteF
force-pushed
the
run-test-pg-upgrade-fix
branch
from
1b1818c to
d1a3c2e
Compare
In #6814 we started using the Python test runner for upgrade tests in run_test.py, instead of the Perl based one. This had a problem though, not all tests in minimal_schedule can be run with the Python runner. This adds a separate minimal schedule for the pg_upgrade tests which doesn't include the tests that break with the Python runner.
JelteF
force-pushed
the
run-test-pg-upgrade-fix
branch
from
d1a3c2e to
cb6a2df
Compare
onurctirtir
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Verified that this helps flaky test detection test in #6866 to pass (once I rebase it), thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6814 we started using the Python test runner for upgrade tests in
run_test.py, instead of the Perl based one. This had a problem though,
not all tests in minimal_schedule can be run with the Python runner.
This adds a separate minimal schedule for the pg_upgrade tests which
doesn't include the tests that break with the Python runner.
This PR also fixes various other issues that came up while testing
the upgrade tests.