-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional alter database propagation support #7253
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7253 +/- ##
==========================================
- Coverage 89.60% 84.26% -5.35%
==========================================
Files 278 350 +72
Lines 60099 62696 +2597
Branches 7487 8126 +639
==========================================
- Hits 53853 52830 -1023
- Misses 4100 7629 +3529
- Partials 2146 2237 +91 |
to fix failing tests
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
…m/citusdata/citus into alter_database_additional_options
…m/citusdata/citus into alter_database_additional_options
I'm checking for Codecov results and see that even the main execution blocks seem uncovered. I think they are false positives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me, let me quickly perform some manual testing while you're addressing those last a few comments.
DESCRIPTION: Adds database connection limit, rename and set tablespace propagation
In this PR, below statement propagations are added
alter database <database_name> with allow_connections = <boolean_value>;
alter database <database_name> rename to <database_name2>;
alter database <database_name> set TABLESPACE <table_space_name>