-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start Maintenance Daemon for Main DB at the server start. #7254
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
87a5fcf
Start Daemon in server startup
emelsimsek 0ba4729
Fix some bugs
emelsimsek 67d6246
Add controldb_name GUC
emelsimsek c26415c
controldb_name should require retsart
emelsimsek b14c5a0
Refactor error handling
emelsimsek 995cb06
Fix comments and error handling
emelsimsek d076b43
Rename GUC
emelsimsek 3d88054
Fix deadlock in regress
emelsimsek 8c033ec
Reindent
emelsimsek 6d7648c
Style
emelsimsek 72899c5
reindent
emelsimsek c28dae5
Add python test
emelsimsek ab6c68e
Add python test
emelsimsek 9b295b9
Fix typo
emelsimsek 075de6a
Fix flakyness
emelsimsek ff817d8
Fix flakyness
emelsimsek ba0377c
Fix flakyness
emelsimsek d6e75f6
test cleanup
emelsimsek 0a0382b
Refactor
emelsimsek afa24ed
Fix process name
emelsimsek 731e9c8
Refactor
emelsimsek bbf316b
Change tests
emelsimsek ea4e9c3
Reformat
emelsimsek 4836ede
Wait until deamon starts in tests
emelsimsek 11a13cc
Improve the test
emelsimsek 9f6e0b8
Add cleanup_databases to cleanup_test_leftovers
emelsimsek 297ef20
Refactor
emelsimsek 0607039
Comments
emelsimsek 2565296
Fix typos
emelsimsek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you treat DB as a word? Should it be
...ForMainDb()
or...ForMainDB()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both styles seem to be used in the codebase. E.g:
bcf54c5#:~:text=MaintenanceDaemonDBData%20*)-,MaintenanceDaemonDBData%20*myDbData%20%3D%20(MaintenanceDaemonDBData%20*),HASH_FIND%2C%20NULL)%3B,-if%20(!myDbData
I do not have a preference.