automatically add a breakpoint that breaks on postgres errors #7279
Conversation
thanodnl
force-pushed
the
devcontainer/break-on-error
branch
from
629bd3a
to
44f25af
Compare
Codecov Report
@@ Coverage Diff @@
## main #7279 +/- ##
=======================================
Coverage ? 93.21%
=======================================
Files ? 275
Lines ? 59532
Branches ? 7416
=======================================
Hits ? 55492
Misses ? 4040
Partials ? 0 |
.devcontainer/.gdbinit
Outdated
| # Lastly the breakpoint doesn't show up in vscode :(, to remove the breakpoint | ||
| # you can use the command `-exec delete <id>` in the vscode debug console. The | ||
| # id is the number in the first column of the breakpoint list which you can | ||
| # show with the command `-exec info break`. |
There was a problem hiding this comment.
It might be good to print (some of) this info, so that people can remove it even if they don't read .gdbinit.
There was a problem hiding this comment.
I like the idea, do you have any idea on how to do so?
I expect you want to print this in the gdb console. The console is pretty verbose when attaching to a running citus backend due to many .so files being loaded.
We van have a look together later today to understand the value of it.
There was a problem hiding this comment.
it looks like this now (when scrolling up)
thanodnl
force-pushed
the
devcontainer/break-on-error
branch
from
cbb3bc0
to
8c860df
Compare
thanodnl
force-pushed
the
devcontainer/break-on-error
branch
from
8c860df
to
8323e53
Compare
When debugging postgres it is quite hard to get to the source for `errfinish` in `elog.c`. Instead of relying on the developer to set a breakpoint in the `elog.c` file for `errfinish` for `elevel == ERROR`, this change adds the breakpoint to `.gdbinit`. This makes sure that whenever a debugger is attached to a postgres backend it will break on postgres errors. When attaching the debugger a small banner is printed that explains how to disable the breakpoint.
When debugging postgres it is quite hard to get to the source for
errfinishinelog.c. Instead of relying on the developer to set a breakpoint in theelog.cfile forerrfinishforelevel == ERROR, this change adds the breakpoint to.gdbinit. This makes sure that whenever a debugger is attached to a postgres backend it will break on postgres errors.When attaching the debugger a small banner is printed that explains how to disable the breakpoint.