CI: move to github container registry #7652
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7652 +/- ##
==========================================
- Coverage 89.70% 89.70% -0.01%
==========================================
Files 283 283
Lines 60508 60507 -1
Branches 7539 7539
==========================================
- Hits 54277 54275 -2
- Misses 4075 4076 +1
Partials 2156 2156 |
| @@ -5,7 +5,7 @@ verify_ssl = true | |||
|
|
|||
| [packages] | |||
| mitmproxy = {editable = true, ref = "main", git = "https://github.com/citusdata/mitmproxy.git"} | |||
| construct = "==2.9.45" | |||
| construct = "*" | |||
There was a problem hiding this comment.
I don't exactly know what I ran here, but it is odd to me that it changed it to a *. Will have a look once I get back to see if I can pin this to the current version to prevent unexpected changes in the future
There was a problem hiding this comment.
I did not really understand how it does not cause any problem for us to have many * versions in the rest of this file. Maybe there is not much risk at all.
There was a problem hiding this comment.
could be, given there are more it might be ok?
| @@ -16,6 +16,7 @@ pytest-timeout = "*" | |||
| pytest-xdist = "*" | |||
| pytest-repeat = "*" | |||
| pyyaml = "*" | |||
| werkzeug = "==2.3.7" | |||
There was a problem hiding this comment.
Guess once this was added the file hasn't been copied to the devcontainer. Guess thats an extra CI job to setup :P. Not super important, but now it will get incorporated with this change.
| @@ -5,7 +5,7 @@ verify_ssl = true | |||
|
|
|||
| [packages] | |||
| mitmproxy = {editable = true, ref = "main", git = "https://github.com/citusdata/mitmproxy.git"} | |||
| construct = "==2.9.45" | |||
| construct = "*" | |||
There was a problem hiding this comment.
I did not really understand how it does not cause any problem for us to have many * versions in the rest of this file. Maybe there is not much risk at all.
We move the CI images to the github container registry. Given we mostly (if not solely) run these containers on github actions infra it makes sense to have them hosted closer to where they are needed. Image changes: citusdata/the-process#157 (cherry picked from commit e776a7e)
We move the CI images to the github container registry.
Given we mostly (if not solely) run these containers on github actions infra it makes sense to have them hosted closer to where they are needed.
Image changes: citusdata/the-process#157