Add docker support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think now its ready for review. Let me know if I should change something. |
balazsdukai
requested changes
Oct 17, 2019
There was a problem hiding this comment.
I made a branch pull/25 with the fixes, I'll try to push it to you fork @vvmruder so it can be added to the PR.
.travis.yml
Outdated
| deploy: | ||
| - provider: script | ||
| script: | ||
| - docker push ${DOCKER_USERNAME}/cjio:latest |
There was a problem hiding this comment.
The 'script' provider requires a string, not an array, so this will fail.
The solution is:
script: docker push ...
.travis.yml
Outdated
| branch: master | ||
| - provider: script | ||
| script: | ||
| - docker tag ${DOCKER_USERNAME}/cjio:latest ${DOCKER_USERNAME}/cjio:dev |
There was a problem hiding this comment.
The same here.
Plus Travis is not happy about multi-line scripts in the deploy section like this one. So better to write it in a single line and use ; to separate the commands.
Btw this is what made the val3dity deploy fail too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make usage easier I offer a docker integrated workflow for this tool. So the dependencies are 'hidden' inside the image.
I also included shapely in this image to make it more easy to solve geometrical problems in python scripts.