Use alternate Mapbox error fix #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mddilley
commented
Mar 15, 2024
| @@ -53,7 +53,7 @@ const ProjectSummaryMap = ({ data }) => { | |||
| ref={mapRef} | |||
| initialViewState={initialViewState} | |||
| style={{ width: "100%", height: "60vh" }} | |||
| mapStyle={basemaps.streets.mapStyle} | |||
| mapStyle={basemaps[basemapKey].mapStyle} | |||
There was a problem hiding this comment.
this is a small fix that I snuck it. The satellite layer in the summary map is working just like in the components map in production, but, in the deploy preview, the layer wouldn't toggle to satellite.
mddilley
requested review from
amenity,
frankhereford,
chiaberry,
johnclary,
tillyw and
roseeichelmann
chiaberry
reviewed
Mar 19, 2024
Comment on lines
-31
to
+41
| "not ie 11", | ||
| ">0.2%", | ||
| "not dead", | ||
| "not op_mini all" | ||
| "not op_mini all", | ||
| "not safari < 10", | ||
| "not chrome < 51", | ||
| "not android < 5", | ||
| "not ie < 12" | ||
| ], | ||
| "development": [ | ||
| ">0.3%", | ||
| "not ie 11", | ||
| "not dead", | ||
| "not op_mini all" | ||
| "last 1 chrome version", | ||
| "last 1 firefox version", | ||
| "last 1 safari version" |
frankhereford
approved these changes
Mar 19, 2024
|
thanks y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues
cityofaustin/atd-data-tech#16245
When we first added
react-map-glv7 during the project components overhaul, there was a error that was fixed using the workaround described in the code here. This implements the recommended fix, and it is the same one used map upgrade in cityofaustin/vision-zero#1398.Testing
URL to test:
https://deploy-preview-1296--atd-moped-main.netlify.app/moped/
Steps to test:
Ship list
Added to QA test script if applicable