Skip to content

Fix typo in argument flag in download_cr3s.py #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2021
Merged

Fix typo in argument flag in download_cr3s.py #1036

merged 2 commits into from
Oct 29, 2021

Conversation

frankhereford
Copy link
Member

I included a typo in the argument flags (-c instead of -v) for enabling verbose output.

mateoclarke
mateoclarke approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@mateoclarke mateoclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frankhereford
frankhereford commented Oct 29, 2021
View reviewed changes
Copy link
Member Author

@frankhereford frankhereford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this last second addition - I was just reviewing my code from today, and I observed that I had a half-cooked usage of the verbose argument. This implements the intended functionality of the verbose progress reporting.

patrickm02L
patrickm02L approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@patrickm02L patrickm02L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V-awesome!

@frankhereford frankhereford merged commit 5a8e66d into master Oct 29, 2021
@frankhereford frankhereford deleted the flh_fix_typo_in_cr3_download_args branch October 29, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoclarke mateoclarke mateoclarke approved these changes

@amenity amenity Awaiting requested review from amenity

@sergiogcx sergiogcx Awaiting requested review from sergiogcx

@chiaberry chiaberry Awaiting requested review from chiaberry

@tillyw tillyw Awaiting requested review from tillyw

+1 more reviewer

@patrickm02L patrickm02L patrickm02L approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankhereford @patrickm02L @mateoclarke