Update timeout in the read replica haproxy configuration #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankhereford
changed the title
frankhereford
requested review from
chiaberry,
johnclary,
tillyw,
mddilley and
roseeichelmann
mddilley
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Looks great! I found this StackExchange thread that helped me understand the config more if anyone is interested. 10 minutes sounds good because I saw some posts that suggest starting at 5. 🚢 🙌
| @@ -5,8 +5,8 @@ defaults | |||
| log global | |||
| mode tcp | |||
| timeout connect 5000ms | |||
| timeout client 50000ms | |||
| timeout server 50000ms | |||
| timeout client 600000ms | |||
There was a problem hiding this comment.
i think that these can be represented in minutes if we wanted. Not really a big deal - i was just curious about it myself.
There was a problem hiding this comment.
Such a good call! Thank you - this is much more readable. a801f9a
chiaberry
approved these changes
Mar 19, 2024
roseeichelmann
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues
This PR aims to close both cityofaustin/atd-data-tech#14987 and cityofaustin/atd-data-tech#16226.
Clarification 🎗️
I had stated that I had not yet pushed up and merged this configuration, but I had. I just didn't remember doing it. It's been in the toolbox all along, and this PR is an update to that configuration.
Testing
This is deployed in production already.
Ship list