Add tooltips to explain what each mode type indicates #1412
Conversation
tillyw
requested review from
johnclary,
frankhereford,
chiaberry,
mddilley and
roseeichelmann
| @@ -222,7 +224,9 @@ const CrashesByMode = () => { | |||
| <Container className="m-0 p-0"> | |||
| <Row> | |||
| <Col> | |||
| <h2 className="text-left, font-weight-bold">By Travel Mode</h2> | |||
| <h2 className="text-left, font-weight-bold">By Travel Mode{" "} | |||
There was a problem hiding this comment.
Could you removed the comma next to this text-left class since you are in here? That snuck its way in there somewhere in the past.
Also, no change needed, but I noticed we use a space character around the app to create space between elements. Probably something we could have reached to CSS styles to achieve!
There was a problem hiding this comment.
thanks for pointing that out, Mike. i would also rather see spacing addressed here with a padding class rather than " ", but i guess we should tackle that separately so that we can fix it everywhere at once?
There was a problem hiding this comment.
+1 - i think that is out of scope too 👍
There was a problem hiding this comment.
thanks, y'all! @mddilley I dropped the comma, thanks for noticing that! and +1 to fixing the spacing using css throughout the app. going to go ahead and merge for the next release !
| @@ -39,6 +39,7 @@ const InfoPopover = ({ config }) => { | |||
| isOpen={modal} | |||
| toggle={toggle} | |||
| zIndex={1305} // Set z-index to supercede SideDrawer and SideMapControlDateRange components | |||
| fade={false} | |||
| @@ -222,7 +224,9 @@ const CrashesByMode = () => { | |||
| <Container className="m-0 p-0"> | |||
| <Row> | |||
| <Col> | |||
| <h2 className="text-left, font-weight-bold">By Travel Mode</h2> | |||
| <h2 className="text-left, font-weight-bold">By Travel Mode{" "} | |||
There was a problem hiding this comment.
thanks for pointing that out, Mike. i would also rather see spacing addressed here with a padding class rather than " ", but i guess we should tackle that separately so that we can fix it everywhere at once?
johnclary
changed the title
Associated issues
fixes cityofaustin/atd-data-tech#15987
Testing
URL to test:
https://deploy-preview-1412--atd-vzv-staging.netlify.app/
Steps to test:
Ship list