Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the VZV metric cards be the same height #1425

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

roseeichelmann
Copy link
Contributor

@roseeichelmann roseeichelmann commented Apr 4, 2024

Associated issues

Closes cityofaustin/atd-data-tech#15888

Testing

URL to test:
https://deploy-preview-1425--atd-vzv-staging.netlify.app/

Steps to test:

  1. See that the metrics cards in the VZV are all the same height!

Ship list

  • Check migrations for any conflicts with latest migrations in master branch
  • Confirm Hasura role permissions for necessary access
  • Code reviewed
  • Product manager approved

@@ -1,12 +1,12 @@
{
"name": "atd-vzv",
"version": "1.40.0",
"version": "1.44.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version hasnt been updated in awhile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops—i missed this when i approved the PR. i'm not sure what the best practice is, but i personally have never edited a package-lock file. i would just let this version get bumped whenever we get around to doing another npm update --save. but if y'all usually bump this version manually, then that's cool 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright i can remove this, i never know what the protocol is. but fwiw i didnt rly do it manually it was from when i ran npm install

<Card>
<CardBody className="h-100 py-0">
<Card className="h-100">
<CardBody className="py-0">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needed to move this "h-100" up a component :)

Copy link
Member

@johnclary johnclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yayyyy thank you! now @chiaberry's eyes will stop bleeding 🚢 🚢 🚢

Copy link
Contributor

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So symmetrical ✨ This looks really great! 🚢

@roseeichelmann roseeichelmann merged commit 4f64652 into master Apr 10, 2024
8 checks passed
@roseeichelmann roseeichelmann deleted the 15888_vzv_metric_cards branch April 10, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bughancement] Make the VZV metric cards be the same height
3 participants