-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump paths-filter version and use setting #1455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any better ideas John, I think your deployment makes sense to me, and at worst, once it's in both places, if we're not satisfied that it's tested sufficiently, we'll be in a place where we can test more easily.
🚢🚢🚢
id: changes | ||
with: | ||
base: ${{ github.ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the magic. Thank you and @chiaberry and everyone for y'all's insight in this. I was struggling to understand all the moving parts of this git operation and what was going on, to say the least. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say YOLO 🚀 🚢 The config makes sense to me, and I agree that merging from master to prod sounds like a good way to test this! 🧪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this 🙏
@johnclary actually, i assumed that you are going to PR this into prod like a patch after merging this one. Does that match up with what you are thinking? |
@mddilley not exactly what i was thinking but that's a great idea 🙏 thanks @chiaberry for untangling what was going on with this issue!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long live the branch!
…ilter-update Patch github action paths-filter in prod (companion to #1455)
Associated issues
The paths-filter docs has an example called
Long lived branches: Detect changes against the most recent commit on the same branch before the push
that covers the behavior that i think we want, by addingbase: ${{ github.ref }}
to our settings.Testing
I think we need to merge this to master and then prod. Got any better ideas?
Ship list