Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set VZV dataset endpoints based on environment #1512

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

johnclary
Copy link
Member

@johnclary johnclary commented Aug 19, 2024

Associated issues

Testing

  1. start your local VZV
  2. Make sure the VZV looks ok. At the moment there's not much data in the staging dataset.
  3. I'm not sure how to test the prod changes?

Ship list

  • Check migrations for any conflicts with latest migrations in master branch
  • Confirm Hasura role permissions for necessary access
  • Code reviewed
  • Product manager approved

Copy link
Contributor

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update and I love the cleanup! I verified the local requests are coming from the test dataset 4x4s, and I feel confident that this will work just fine in prod. 🔥 🚢

@@ -11,7 +11,6 @@ import { Auth0Provider, urlPath, onRedirectCallback } from "./auth/authContext";
import { HashRouter } from "react-router-dom";
import * as serviceWorker from "./serviceWorker";

console.log("🤖 Release Drafter Test");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 We've come a long way since testing the drafter GH action! 📝 💯

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 🔥 🫙 Wow, this code lived in here way longer than our brief test run. I had long forgotten how this connects to the build scripts too.

@johnclary
Copy link
Member Author

Thanks, Mike!!

@johnclary johnclary merged commit fb4cc24 into 18679-misc-loose-ends-iv Aug 20, 2024
@johnclary johnclary deleted the 18689-vzv-env branch August 21, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants