Add total person comp cost to the crash details page #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roseeichelmann
commented
Aug 19, 2024
| - cris_fatality_count | ||
| - est_comp_cost_crash_based | ||
| - est_total_person_comp_cost |
There was a problem hiding this comment.
just added this and other stuff got rearranged
roseeichelmann
commented
Aug 19, 2024
| @@ -41,6 +41,7 @@ | |||
| - "!include lookups_veh_mod.yaml" | |||
| - "!include lookups_wthr_cond.yaml" | |||
| - "!include public__column_metadata.yaml" | |||
| - "!include public__cris_import_log.yaml" | |||
There was a problem hiding this comment.
idk why this moved 🤷
roseeichelmann
requested review from
frankhereford,
chiaberry,
johnclary,
tillyw and
mddilley
mddilley
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Took me a second to understand the difference between these two fields but the DB showed me the way ✨
johnclary
requested changes
Aug 20, 2024
| format: "dollars", | ||
| }, | ||
| est_total_person_comp_cost: { | ||
| label: " Total Est. Comprehensive Cost", |
There was a problem hiding this comment.
Looks like this leading whitespace space can be removed
johnclary
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues
Closes cityofaustin/atd-data-tech#18683
Testing
URL to test:
Local data model
Steps to test:
Ship list