Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory existence check to CRIS import script #1519

Closed
wants to merge 1 commit into from

Conversation

frankhereford
Copy link
Member

@frankhereford frankhereford commented Aug 21, 2024

Issue

While standing up the VZ data model locally, I found that there are a heterogeneous set of CRIS extracts in the dev inbox; some have PDFs in them, some don't, it appears.

This small diff adds a check to utils.process_pdfs() to return early if there is not a directory of PDFs to process for a given zip.

Associated issues

nada

Testing

Import the CRIS extracts currently in the dev inbox.


Ship list

  • Check migrations for any conflicts with latest migrations in master branch
  • Confirm Hasura role permissions for necessary access
  • Code reviewed
  • Product manager approved

@frankhereford
Copy link
Member Author

@johnclary already had a PR cooking with this fix and others: #1518. Thanks!

@frankhereford frankhereford deleted the check_if_pdf_directory_exists branch August 21, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant