VZV | Add padding to bottom text in summary widgets #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiogcx
reviewed
Aug 14, 2020
Comment on lines
+90
to
+92
| <span className="text-muted text-wrap pl-4"> | ||
| {`${text} ${numberWithCommas(lastYearTotal)} this time last year`} | ||
| </div> | ||
| </span> |
There was a problem hiding this comment.
Cool stuff! Clever change!
sergiogcx
reviewed
Aug 14, 2020
Comment on lines
+38
to
+45
| .widget-body { | ||
| height: 70%; | ||
| } | ||
|
|
||
| .widget-footer { | ||
| height: 30%; | ||
| } | ||
|
|
sergiogcx
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cityofaustin/atd-data-tech#3650
This PR updates the
SummaryWidgetcomponent styles to keep the padding within the card footers and the card heights even across the widgets whether the text wraps or not. The height of the card body and footer were change from 75%/25% to 70%/30% and then some custom CSS was replaced with Bootstrap classes to keep the arrows and text in the footer vertically aligned.Update screenshots