Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .mjs for module build #339

Closed
wants to merge 1 commit into from
Closed

Conversation

realityking
Copy link
Contributor

This will improve compatability with Node.js

This will improve compatability with Node.js
@trotzig
Copy link
Collaborator

trotzig commented Nov 17, 2020

We had this a (long) while back but had to revert because it broke things for a lot of people. It might be worth reading up on some discussions there:

Introduced in
#220

Reverted in
#223

There's been a lot of water under the bridge since then however, and it might be just fine to make this change today.

@realityking
Copy link
Contributor Author

The most relevant discussion seem to be in #234 and #221

I think this might've been fixed by #286 but I'm also not confident so I'm gonna close this one.

Until react-waypoint actually adds an export map to run modules in Node it doesn't give any benefit anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants