APIv4 - Simplify entity creation in test suite

Removes the old v3 creation and hardcoded sample data in favor of
new `createTestRecord` and `saveTestRecords` methods which automatically
handle cleanup during tearDown.

CRM/Core/BAO/CustomGroup.php

@@ -40,6 +40,8 @@ public static function self_hook_civicrm_post(\Civi\Core\Event\PostEvent $e): vo
    * @throws \Exception
    */
   public static function create(&$params) {
+    // This is the database default
+    $params += ['extends' => 'Contact'];
     // create custom group dao, populate fields and then save.
     $group = new CRM_Core_DAO_CustomGroup();
     if (isset($params['title'])) {

Civi/Api4/Service/Spec/Provider/CustomGroupSpecProvider.php

@@ -23,7 +23,6 @@ public function modifySpec(RequestSpec $spec) {
     $action = $spec->getAction();
 
     $spec->getFieldByName('extends')
-      ->setRequired($action === 'create')
       ->setSuffixes(['name', 'label', 'grouping']);
   }
 

Civi/Api4/Service/Spec/Provider/MembershipTypeCreationSpecProvider.php

@@ -0,0 +1,38 @@
+<?php
+
+/*
+ +--------------------------------------------------------------------+
+ | Copyright CiviCRM LLC. All rights reserved.                        |
+ |                                                                    |
+ | This work is published under the GNU AGPLv3 license with some      |
+ | permitted exceptions and without any warranty. For full license    |
+ | and copyright information, see https://civicrm.org/licensing       |
+ +--------------------------------------------------------------------+
+ */
+
+namespace Civi\Api4\Service\Spec\Provider;
+
+use Civi\Api4\Service\Spec\RequestSpec;
+
+class MembershipTypeCreationSpecProvider implements Generic\SpecProviderInterface {
+
+  /**
+   * @param \Civi\Api4\Service\Spec\RequestSpec $spec
+   */
+  public function modifySpec(RequestSpec $spec): void {
+    $spec->getFieldByName('duration_interval')->setRequired(TRUE);
+  }
+
+  /**
+   * When does this apply.
+   *
+   * @param string $entity
+   * @param string $action
+   *
+   * @return bool
+   */
+  public function applies($entity, $action): bool {
+    return $entity === 'MembershipType' && $action === 'create';
+  }
+
+}

tests/phpunit/api/v4/Action/ContactGetTest.php

@@ -330,9 +330,7 @@ public function testAge(): void {
       ['first_name' => 'abc', 'last_name' => $lastName, 'birth_date' => 'now - 1 year - 1 month'],
       ['first_name' => 'def', 'last_name' => $lastName, 'birth_date' => 'now - 21 year - 6 month'],
     ];
-    Contact::save(FALSE)
-      ->setRecords($sampleData)
-      ->execute();
+    $this->saveTestRecords('Contact', ['records' => $sampleData]);
 
     $result = Contact::get(FALSE)
       ->addWhere('last_name', '=', $lastName)
@@ -347,4 +345,28 @@ public function testAge(): void {
       ->execute()->single();
   }
 
+  /**
+   *
+   */
+  public function testGetWithCount() {
+    $myName = uniqid('count');
+    for ($i = 1; $i <= 20; ++$i) {
+      $this->createTestRecord('Contact', [
+        'first_name' => "Contact $i",
+        'last_name' => $myName,
+      ]);
+    }
+
+    $get1 = Contact::get(FALSE)
+      ->addWhere('last_name', '=', $myName)
+      ->selectRowCount()
+      ->addSelect('first_name')
+      ->setLimit(10)
+      ->execute();
+
+    $this->assertEquals(20, $get1->count());
+    $this->assertCount(10, (array) $get1);
+
+  }
+
 }