Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter current employer report by all groups #12643

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

jmcclelland
Copy link
Contributor

Code only filtered by static groups before.

https://lab.civicrm.org/dev/core/issues/320

Overview

Update the current Employer report so you can filter by all groups, not just static groups.

Before

Previously, the only groups listed in the Filter tab, Group field are static groups. You can't filter the report by smart groups.

After

You can filter by all groups.

Technical Details

The old code included a stanza for the group filter which specified the options using CRM_Core_PseudoConstant::staticGroup(). The new code eliminates the stanza and sets _groupFilter = TRUE;

@civibot
Copy link

civibot bot commented Aug 10, 2018

(Standard links)

@colemanw
Copy link
Member

@colemanw colemanw merged commit 635c3d9 into civicrm:master Aug 13, 2018
MegaphoneJon added a commit to MegaphoneJon/civicrm-core that referenced this pull request Aug 17, 2018
yashodha added a commit that referenced this pull request Aug 17, 2018
…ilter

Replicate fix on PR #12643 for pledge report
mattwire pushed a commit to mattwire/civicrm-core that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants