dev/core#299 Fix mishandling of non decimal currency on update payment details form #12684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@mattwire wanna rebase this? |
mattwire
force-pushed
the
money_fn_update_payment_details
branch
from
f77eea8 to
77ea722
Compare
mattwire
changed the title
mattwire
changed the title
|
@eileenmcnaughton Now rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up to #12626
Fixes display of amount on UpdatePaymentDetails form
Before
After
Technical Details
Amount is read-only and only used for display - it is not used in postProcess at all so we don't need to worry about formatting to save it.
https://lab.civicrm.org/dev/core/issues/299