-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve styling of address block on summary screen #12723
Conversation
(Standard links)
|
@tschuettler I'm on a contact summary improvement kick right now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colemanw I agree that it does make more sense to display the label all the time.
It currently does not work for multiple addresses.
I'm not sure whether multiple addresses should stay more compact by spanning over both columns or using the same design as the other elements like E-Mail or Phone.
css/contactSummary.css
Outdated
@@ -77,6 +77,10 @@ div#crm-contact-thumbnail { | |||
display: none !important; | |||
} | |||
|
|||
#crm-container .crm-address-block+.crm-address-block .crm-summary-row { | |||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also hides all other other adresses and just leaves the primary one.
The extension looks like a really nice feature! We currently get along with ACL-based display of custom field sets reasonably well. |
@tschuettler whoops, that was a mistake. Now fixed. |
test this please |
I can confirm that it works again: It seems like #12708 introduced the odd spacing between multiple addresses in 8fa8736#diff-6e4b278c9fc95f56b5040a44db65e310R25 Do we need that there or can we add something with more specificty to counter it? .crm-address-block {
clear: none;
} |
Thanks @tschuettler - you're right that |
Thanks @colemanw - it's looking good now. |
@civicrm-builder retest this please |
Overview
More consistent styling of the address block with other elements of the contact summary screen; makes the block easier to see when the contact does not have an address.
Before
After
Before (w Shoreditch)
After (w Shoreditch)