Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling of address block on summary screen #12723

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 23, 2018

Overview

More consistent styling of the address block with other elements of the contact summary screen; makes the block easier to see when the contact does not have an address.

Before

screenshot from 2018-08-23 11-40-54

After

screenshot from 2018-08-23 11-37-52

Before (w Shoreditch)

screenshot from 2018-08-23 11-36-23

After (w Shoreditch)

screenshot from 2018-08-23 11-36-47

@civibot
Copy link

civibot bot commented Aug 23, 2018

(Standard links)

@colemanw
Copy link
Member Author

@tschuettler I'm on a contact summary improvement kick right now!
BTW have you seen the new Layout Editor extension?

Copy link
Contributor

@tschuettler tschuettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colemanw I agree that it does make more sense to display the label all the time.

It currently does not work for multiple addresses.
I'm not sure whether multiple addresses should stay more compact by spanning over both columns or using the same design as the other elements like E-Mail or Phone.

This contact has actually 4 addresses:
grafik

@@ -77,6 +77,10 @@ div#crm-contact-thumbnail {
display: none !important;
}

#crm-container .crm-address-block+.crm-address-block .crm-summary-row {
display: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also hides all other other adresses and just leaves the primary one.

@tschuettler
Copy link
Contributor

The extension looks like a really nice feature! We currently get along with ACL-based display of custom field sets reasonably well.

@colemanw
Copy link
Member Author

@tschuettler whoops, that was a mistake. Now fixed.

@eileenmcnaughton
Copy link
Contributor

test this please

@tschuettler
Copy link
Contributor

I can confirm that it works again:
grafik

It seems like #12708 introduced the odd spacing between multiple addresses in 8fa8736#diff-6e4b278c9fc95f56b5040a44db65e310R25

Do we need that there or can we add something with more specificty to counter it?

.crm-address-block {
    clear: none;
}

This would look better to me:
grafik

@colemanw
Copy link
Member Author

Thanks @tschuettler - you're right that clear:both was causing problems. I've removed it as it wasn't really essential to the previous PR; I had added it "just in case" but if it's causing problems, let's get rid of it.

@tschuettler
Copy link
Contributor

Thanks @colemanw - it's looking good now.

@colemanw
Copy link
Member Author

@civicrm-builder retest this please

@colemanw colemanw merged commit 2b29a14 into civicrm:master Aug 29, 2018
@eileenmcnaughton eileenmcnaughton deleted the addressBlock branch August 29, 2018 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants