Token changes #13174
Closed
Token changes #13174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
getValue blows up if value is not set, so use getSingle instead
|
@eileenmcnaughton The things left here now are fairly small. Can we consider these in one PR or do I need to split out further? |
| $fieldValue = civicrm_api3($entity, 'getvalue', array( | ||
| 'return' => $customFieldName, | ||
| 'id' => $entityID, | ||
| $record = civicrm_api3($entity, "getSingle", array( |
There was a problem hiding this comment.
not having a return does impact the speed of the api - esp on contribution.get -
| @@ -71,14 +71,22 @@ public static function getSubscribedEvents() { | |||
|
|
|||
There was a problem hiding this comment.
So I feel like I understand the changes to this file really well now :-) If you push them up separately I can merge them quick
This was referenced Dec 14, 2018
Merged
|
@aydun can you please rebase this? |
|
@eileenmcnaughton The only piece of this now remaining is #13283 so I'll close this one. Getting that merged is the last item before rebasing #12012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A variety of changes affecting the TokenProcessor - see git commits. These are extracted from PR #12012 and new functionality is used in that PR
There are no user changes here.