Display error instead of fatal error when trying to view a case that you don't have permission to access

[mattwire]

Overview

The fatal error page is not user-friendly and suggests something has gone wrong with the system - it is also deprecated. In this case the fatal error page is shown if you click "Manage" on a case which you don't have permission to access - this PR changes that to statusBounce() so the user remains on the case dashboard and is shown an error popup instead.

Before

Fatal error page when trying to access case from dashboard with filter set to "All cases" and clicking "Manage" on a case that you do not have access to.

After

"Friendly error" when trying to access case from dashboard with filter set to "All cases" and clicking "Manage" on a case that you do not have access to.

Technical Details

In general swapping CRM_Core_Error::fatal() for CRM_Core_Error::statusBounce() is ok for forms when something "normal" is happening. An SQL query failure for example you might expect to see the fatal error screen as that is not a "normal" situation.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).