l10n.js - Reload when logging in as new user #13518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| 'r' => $this->getCacheCode(), | ||
| 'cid' => CRM_Core_Session::getLoggedInContactID(), | ||
| ]; | ||
| $this->addScriptUrl(CRM_Utils_System::url('civicrm/ajax/l10n-js/' . $tsLocale, $args, FALSE, NULL, FALSE), $jsWeight++, $region); |
There was a problem hiding this comment.
@colemanw is there anything that is needed here to trigger the re-loading if the cid doesn't match or does it do that automatically?
There was a problem hiding this comment.
The changed value of the cid url param breaks browser caching so it reloads automatically.
There was a problem hiding this comment.
I think the point is the url will be different & hence not treated the same?
There was a problem hiding this comment.
yep happy with that just wanted to double check the logic good to merge from me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prevents a potential bug where clientside settings are served from a stale browser cache when switching users.
Before
Settings that depend on the user's permissions may not be correct when switching users. To reproduce:
After
Buttons always appear correctly.