[WIP] dev/core#980 [test-dbunit] remove use of discontinued phpunit/dbunit #14268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
eileenmcnaughton
force-pushed
the
test_dbunit
branch
2 times, most recently
from
4ceeb61 to
45fa100
Compare
|
@seamuslee001 OK - I got past that bit - lessee |
|
Jenkins doesn't like your style @eileenmcnaughton https://test.civicrm.org/job/CiviCRM-Core-PR/26195/checkstyleResult/new/ |
eileenmcnaughton
force-pushed
the
test_dbunit
branch
from
45fa100 to
90c4471
Compare
eileenmcnaughton
force-pushed
the
test_dbunit
branch
4 times, most recently
from
46c4e6e to
c771a45
Compare
eileenmcnaughton
force-pushed
the
test_dbunit
branch
3 times, most recently
from
c216e73 to
b6d0ebe
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
added 6 commits
May 22, 2019 07:34
The phpunit/dbunit package has been discontinued. I've removed the reference to it from the top level extends and one call to it & the test I tried locally passes so it's not needed for ALL tests. Let's see where it IS needed & what our options are - have at it jenkins
eileenmcnaughton
force-pushed
the
test_dbunit
branch
from
b6d0ebe to
2294814
Compare
|
closing for now - sub-prs still progressing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove obsolete phphunit/dbunit package from our test suite
sebastianbergmann/dbunit#217
Removing our dependency on this removes a hurdle in supporting more recent phpunit versions since we need to migrate over our own classes to extend the namespaced classes, but currently they extend a dbunit class so getting rid of that is a first useful step.
Before
phpunit/dbunit used in tests
After
phpunit/dbunit not used in tests
Technical Details
I came into this as the path to updating our phpunit version expectations requires us to start changing how we call phpunit & the path for this is much less clear ... and then it stops
The phpunit/dbunit package has been discontinued. I've removed the reference to it from the top level
extends and one call to it & the test I tried locally passes so it's not needed for ALL tests.
Let's see where it IS needed & what our options are - have at it jenkins
Comments