dev/membership/#16 Fix duplicate lineitems when creating a recurring membership via backend

[mattwire]

Overview

See https://lab.civicrm.org/dev/membership/issues/16

Before

Cannot create new recurring membership via credit card via backend

After

Can

Technical Details

We just need to update the check for a contribution ID.

Comments

@MegaphoneJon Please can you test?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[MegaphoneJon]

I just did an r-run and can confirm that this fixes the problem. I don't have a super-strong sense of this part of the code, but the change looks sensible from what I understand.

[seamuslee001]

@mattwire should we put this against the RC?

[MegaphoneJon]

@seamuslee001 IMO definitely, since this is a regression from 5.16.

[mattwire]

@MegaphoneJon @seamuslee001 Rebased against 5.18 RC @eileenmcnaughton are you able to take a quick look at this fix for the regression?

[seamuslee001]

@mattwire, Eileen has been away i think and not sure when she will come back

[mattwire]

@seamuslee001 Ok, I thought it would be good to get a second opinion from someone who's familiar with the cleanup/refactoring we're doing in this area. That said, I'm happy with the patch, it's simple and clear. It's also been tested by @MegaphoneJon so your call if you'd like to merge :-)

[seamuslee001]

Given Jon's testing i'm going to merge this and if @eileenmcnaughton wants something else she can make the code changes