Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Import] Stop passing unused parameter #23421

Merged
merged 1 commit into from
May 11, 2022
Merged

[Import] Stop passing unused parameter #23421

merged 1 commit into from
May 11, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[Import] Stop passing unused parameter

Before

the run function no longer uses $mapper but it is still passed in...

image

After

poof

Technical Details

I left out the follow on cleanup because it's over 2 classes & would be a lot to read in one PR

Comments

@civibot
Copy link

civibot bot commented May 10, 2022

(Standard links)

@civibot civibot bot added the master label May 10, 2022
@demeritcowboy demeritcowboy merged commit cc2db5b into civicrm:master May 11, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_obs branch May 11, 2022 02:48
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @demeritcowboy