Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] Simplify if - exit loop early #23427

Merged
merged 1 commit into from
May 11, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 11, 2022

Overview

[REF] [Import] Simplify if - exit loop early

image

Before


All the functional code in the foreach loop is wrapped in if (isset($importedValue))

image

After

The IF is removed in favour of an early exit from the loop if $importedValue is NULL

Technical Details

Lots of whitespace - use w=1 to view

Comments

@civibot
Copy link

civibot bot commented May 11, 2022

(Standard links)

@civibot civibot bot added the master label May 11, 2022
@eileenmcnaughton
Copy link
Contributor Author

@colemanw this should be an easy merge

@colemanw
Copy link
Member

You're right, that WAS easy! All I had to do was close my eyes and hit the merge button.

@colemanw colemanw merged commit fec18a5 into civicrm:master May 11, 2022
@colemanw colemanw deleted the get_mapped_params branch May 11, 2022 23:58
@eileenmcnaughton
Copy link
Contributor Author

lol - I can suggest some more then....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants