[REF] [Import] Parser cleanup #23442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I agree with the cleanup changes, did r-run on my local and looks good. The added unit-tests are apt. Just a minor cleanup is needed. |
monishdeb
added
the
merge ready
monishdeb
reviewed
May 12, 2022
| @@ -0,0 +1 @@ | |||
| ,eileen,eileen-laptop,11.05.2022 11:24,file:///home/eileen/.config/libreoffice/4; | |||
There was a problem hiding this comment.
@eileenmcnaughton I think you accidentally included this file ?
There was a problem hiding this comment.
@monishdeb arg - yes - just removed it
eileenmcnaughton
force-pushed
the
import_data
branch
from
9999390 to
79d21b5
Compare
|
This was just pending me removing the extraneous file - merging now it is gone & the tests have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#23429 and #23431 and #23430 combined - to enable a single r-run