(NFC) karma - Enable all Civi components (not just CiviCase) #23450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ------ If you enable `debug_mode=1` and run `karma`, it produces a large number of failures: ``` PhantomJS 2.1.1 (Mac OS 0.0.0): Executed 81 of 81 (55 FAILED) (2.686 secs / 2.387 secs) ``` After ----- If you enable `debug_mode=1` and run `karma`, it passes: ``` PhantomJS 2.1.1 (Mac OS 0.0.0): Executed 81 of 81 SUCCESS (7.232 secs / 6.95 secs) ``` Comments -------- The `jsonFormatter` plugin is a DX nicety; when browsing a page with `?angularDebug=1` and with `debug_mode=1`, it will load extra files so that `<crm-ui-debug>` panels look pretty. But ordinarily, loading these files is extraneous.
This is a small cleanup (suggested by @colemanw) that makes the `karma.conf.js` appear more general. It modifies the startup process for a test-runner; as long as the test-runner still gives the same output, it should be safe. Before ------ `karma` loads baseline Angular modules and CiviCase Angular modules. After ----- `karma` loads baseline Angular modules and any/all component-based Angular modules Comment ------- Why was it only CiviCase? Not certain... but I *think* it's because (historically) `crmMailing.ang.php` did extra work to build `settings`, and this extra work was a bit too heavy. That work has moved (`settings` became `settingsFactory`) and maybe makes this safer.
|
(Standard links)
|
|
Looks good to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a small cleanup (suggested by @colemanw) that makes the
karma.conf.jsappear more general.It modifies the startup process for a test-runner; as long as the test-runner still gives the same output, it should be safe.
(Note: The patch extends/depends upon #23449 because they modify adjacent lines. But functionally, they're separate.)
Before
karmaloads baseline Angular modules and CiviCase Angular modules.After
karmaloads baseline Angular modules and any/all component-based Angular modulesComment
Why was it only CiviCase? Not certain... but I think it's because (historically)
crmMailing.ang.phpdid extra work to buildsettings, and this extra work was a bit too heavy. That work has moved (settingsbecamesettingsFactory) and maybe makes this safer.