Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Respect max length for name with export action #23472

Merged
merged 1 commit into from
May 17, 2022

Conversation

colemanw
Copy link
Member

Overview

When using the APIv4 Export action, make sure the name of each exported item is not longer than allowed by the civicrm_managed table.

Before

Issue noted in #23452 (comment)

After

Length constrained.

Technical Details

IMO the maxlength of 127 is unnecessarily short, but the fix isn't a simple matter of increasing it because extensions typically support multiple versions of CiviCRM.

Comments

Note that the export action is simply a code generator, so this isn't directly causing a runtime error, but it's still nice to generate working code.

@civibot
Copy link

civibot bot commented May 17, 2022

(Standard links)

@seamuslee001
Copy link
Contributor

Looks fine to me

@seamuslee001 seamuslee001 merged commit fcc043e into civicrm:master May 17, 2022
@seamuslee001 seamuslee001 deleted the exportMaxLentgh branch May 17, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants