[Import] Check subtype validity in validate rather than wait for 'import', test #23491
Conversation
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_sub
branch
7 times, most recently
from
5b20d04 to
5f6ad41
Compare
|
test this please |
| * @throws \CRM_Core_Exception | ||
| * @throws \Civi\API\Exception\UnauthorizedException | ||
| */ | ||
| private function validateMultiRowCsv(string $csv, array $mapper, string $field): void { |
There was a problem hiding this comment.
Since the assertion here seems new+important, I figured I'd kick the tires on it. If I randomly throw in bad data, it complains. So that's good. :)
I'm not sure I understand the signature. $csv makes sense as filename. What are $mapper and $field? (Docblock would be good - but doesn't have to be on this PR specifically.)
There was a problem hiding this comment.
mapper is pretty integral to the concept of these import forms - as the array that is submitted as the mappings - it's documented in quite a few places - I can perhaps find a 'see'. I'm starting to think $field might get removed again in later tests as I start to build on it.
|
@totten just checking back on this since you seem to be onto something new now - was anything blocking here? |
|
this is stale - rebasing now |
eileenmcnaughton
force-pushed
the
import_sub
branch
from
5f6ad41 to
1ac6d38
Compare
|
@totten I updated the comments about 'mapper' - I am surprised my comment updates got through jenkins first go - 1 to me |
|
This needs another rebase - doing now |
eileenmcnaughton
force-pushed
the
import_sub
branch
2 times, most recently
from
0dcdd7d to
a165be6
Compare
|
Since this keeps going stale I've pulled out the comments fix here - #23517 in the hope I can get that merged quickly. I'm also going to pull out some of the bits in this PR that keep going stale / interact with other PRs |
eileenmcnaughton
force-pushed
the
import_sub
branch
4 times, most recently
from
1c5a23d to
4eee6b7
Compare
eileenmcnaughton
force-pushed
the
import_sub
branch
from
4eee6b7 to
a8f0bb9
Compare
|
still dealing with conflicts from other PRs - I split off another small chunk to #23523 |
|
thanks @demeritcowboy this looks like the pr doesn't have all the stuff in it it used to - did I lose it in my rebasing |
|
Actually it wasn't this one I merged. Github is just displaying it that way because after other merges this must have been what was left, and then when I merged that other PR it knows there's nothing left here. |
|
@demeritcowboy yeah - I was excited it was merged - but in all the rebasing I think the meaningful commits fell out - will re-do |
|
OK - I think this was the remaining commit #23526 |
Overview
[Import] Check subtype validity in validate rather than wait for 'import', test
Before
Validate routine does not check for contact subtype validity - but it will (often) fail on import
After
getParamsdoes the mapping to ensure we have a name & then this can be checked during validationTechnical Details
Test cover added
Comments