Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove always-true if-check #23530

Merged
merged 1 commit into from
May 21, 2022
Merged

Remove always-true if-check #23530

merged 1 commit into from
May 21, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove always-true if-check

Before

image

However - we no longer ever set $this->_retCode to CRM_Import_Parser::NO_MATCH and it is now always NULL at this point

After

poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 20, 2022

(Standard links)

@civibot civibot bot added the master label May 20, 2022
@eileenmcnaughton eileenmcnaughton merged commit 1ce34b6 into civicrm:master May 21, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_gone branch May 21, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw