[REF] Minor simplification on input #23536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Minor simplification on input
We are passing in
$params
but it is ONLY used to get$params['custom_' . $customFieldID]
- the same thing that is held in$value
- which should be more reliable on the address check for what it's worth given this is a bit of an obscure checkBefore
private function validateCustomField($customFieldID, array $customFields, array $params, $value, $dateType): ?string {
After
private function validateCustomField($customFieldID, array $customFields, $value, $dateType): ?string
Technical Details
solid test cover in
testValidateDateData
Comments