Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Minor simplification on input #23536

Merged
merged 1 commit into from
May 23, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 21, 2022

Overview

[REF] Minor simplification on input

We are passing in $params but it is ONLY used to get $params['custom_' . $customFieldID] - the same thing that is held in $value - which should be more reliable on the address check for what it's worth given this is a bit of an obscure check

image

Before

private function validateCustomField($customFieldID, array $customFields, array $params, $value, $dateType): ?string {

After

private function validateCustomField($customFieldID, array $customFields, $value, $dateType): ?string

Technical Details

solid test cover in testValidateDateData

Comments

@civibot
Copy link

civibot bot commented May 21, 2022

(Standard links)

@civibot civibot bot added the master label May 21, 2022
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw colemanw merged commit 249b561 into civicrm:master May 23, 2022
@colemanw colemanw deleted the import_cust branch May 23, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants