[Joomla 4.0] Fatal error on submitting Profile with CMS username/password #23549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Utils/System/Joomla.php
Outdated
|
|
||
| if (version_compare(JVERSION, '4.0.0', 'ge')) { | ||
| $model = JFactory::getApplication()->bootComponent('com_users')->getMVCFactory()->createModel('Registration', 'Site'); | ||
| $model->set('data', new \stdClass); |
There was a problem hiding this comment.
@monishdeb can you change this to
Suggested change
| $model->set('data', new \stdClass); | |
| $model->set('data', new \stdClass()); |
There was a problem hiding this comment.
hmm didn't know that stylechecker didn't allow the without parenthesis new class declaration like here
Updating now.
|
This fixes the problem for Joomla 4 for me, and doesn't impact account creation profile pages on Joomla 3. |
|
Thanks @vingle for reviewing this fix. @mlutfy @eileenmcnaughton @colemanw can you please review/merge this PR. |
|
Since this only affects Joomla! I am happy to merge based on @vingle review - thanks @monishdeb @vingle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Steps to replicate:
- Choose any Profile and enable 'User Registration'
- Open the Profile in create mode and submit as a anonymous user.
Before
Result: Fatal error and the joomla user account is not created
After
CMS User and civicrm contact is created successfully
Comments
Ref : https://lab.civicrm.org/dev/joomla/-/issues/39