Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Import] [Ref] Trivial - fold function contents back into parent #23610

Merged
merged 1 commit into from
May 30, 2022
Merged

[Import] [Ref] Trivial - fold function contents back into parent #23610

merged 1 commit into from
May 30, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

The parent is actually longer by virtue of calling the child than without it....

This is in heavily tested code

@civibot
Copy link

civibot bot commented May 27, 2022

(Standard links)

@civibot civibot bot added the master label May 27, 2022
@eileenmcnaughton
[Import] [Ref] Trivial - fold function contents back into parent
e77978b 
The parent is actually longer by virtue of calling the child than without it....
@eileenmcnaughton
Copy link
Contributor Author

@yashodha - if you are still looking at PRs - I think this is kinda & hopefully an easy merge

@yashodha
Copy link
Contributor

@eileenmcnaughton looks good, merging this as well. Thanks!

@yashodha yashodha merged commit 049f56c into civicrm:master May 30, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_dupe branch May 30, 2022 11:30
@eileenmcnaughton
Copy link
Contributor Author

yay - thanks @yashodha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @yashodha