Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables #23613

Merged
merged 1 commit into from
May 29, 2022
Merged

Remove unused variables #23613

merged 1 commit into from
May 29, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

image

@civibot
Copy link

civibot bot commented May 27, 2022

(Standard links)

@civibot civibot bot added the master label May 27, 2022
@colemanw colemanw merged commit 38297d3 into civicrm:master May 29, 2022
@colemanw colemanw deleted the member_unused branch May 29, 2022 15:42
colemanw
colemanw reviewed May 29, 2022
View reviewed changes
CRM/Member/Import/Form/MapField.php
@@ -107,13 +107,9 @@ public function buildQuickForm() {
else {
$savedMapping = $this->get('savedMapping');

list($mappingName, $mappingContactType, $mappingLocation, $mappingPhoneType, $mappingRelation) = CRM_Core_BAO_Mapping::getMappingFields($savedMapping);
list($mappingName) = CRM_Core_BAO_Mapping::getMappingFields($savedMapping);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you can use the new square bracket syntax instead of list()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemanw colemanw colemanw left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw