Simplify return from createContact #23635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_unreach2
branch
2 times, most recently
from
3955cf9 to
ad66a65
Compare
| @@ -472,7 +465,7 @@ public function import($onDuplicate, &$values) { | |||
| $this->_newRelatedContacts[] = $relativeContact[] = $relContactId; | |||
| } | |||
|
|
|||
| if (is_array($relatedNewContact) || ($relatedNewContact instanceof CRM_Contact_BAO_Contact)) { | |||
| if (1) { | |||
There was a problem hiding this comment.
left for now for whitespace readability
eileenmcnaughton
force-pushed
the
import_unreach2
branch
from
ad66a65 to
f4b87bc
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Simplify return from createContact
This is a continuation from #23634 - continuing to simplify the handling of what is returned from
createContactBefore
the found
$idsare wrapped in an error arrayAfter
They are just returned - we already know that an array means duplicates found
Technical Details
This is the crux of it
Comments