dev/core#3498 Fix mishandled option values #23736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_multi
branch
from
a975ea3 to
332fe30
Compare
|
civibot, test this please |
totten
reviewed
Jun 9, 2022
| $this->createCustomGroupWithFieldOfType(['is_multiple' => TRUE, 'extends' => 'Contact'], 'select', 'level'); | ||
| $customGroupID = $this->ids['CustomGroup']['level']; | ||
| $dateFieldID = $this->createDateCustomField(['date_format' => 'yy', 'custom_group_id' => $customGroupID])['id']; | ||
| $this->importCSV('custom_data_date_select.csv', [ |
There was a problem hiding this comment.
There's a test failure:
fopen(/home/jenkins/bknix-dfl/build/core-23736-3prig/web/sites/all/modules/civicrm/tests/phpunit/CRM/Custom/Import/Parser/data/custom_data_date_select.csv): Failed to open stream: No such file or directory
I think maybe this file wasn't committed?
There was a problem hiding this comment.
Nice change from the extra file commits @demeritcowboy has been culling for me :-)
|
I did some Added a comment about a test failure. I think if that's resolved, then we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#3498 Fix mishandled option values
Before
Options are not validated for multi-record custom import
After
Options are validated
'guessing' of fields is working better -in 5.50 looks like
but with this PR
Technical Details
The issue was the code to load the valid options for each field was not working on multi-value custom record sets
Comments
Data patterns -do they REALLY add any value? I feel like they make it more confusing...