Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduepe - Fix form buttons (again) #23757

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

colemanw
Copy link
Member

Overview

Yet another fix for the dedupe form buttons. This feels like a duplicate of the duplicate fix in #23035 but hopefully fixed for real this time and we can stop duplicating these duplicate button fixes!

Before

See dev/core#3421
Also see dev/core#3135
And the original cause: a6f2a80

After

With this patch in place I've tried out all the buttons in all the different contexts and they all seem to be behaving correctly:

Search Mode

  • ✔️ Clicking merge from advanced search action redirects to the contact
  • ✔️ Clicking merge from search kit modal gives success msg and closes the modal

Dedupe Find Mode

  • ✔️ Clicking "Merge and View Result" takes you to the contact record.
  • ✔️ Clicking "Merge and go to listing" takes you back to the list of duplicates.
  • ✔️ Clicking "Merge and go to next pair" takes you to the next set of duplicates.

Technical Details

The problem is that the form is used in different contexts and it's a complex multi-step form, but it can also be used as a one-step form via search and it can also be loaded in an ajax modal. So getting the buttons to behave in every context is tricky.

@civibot
Copy link

civibot bot commented Jun 10, 2022

(Standard links)

@civibot civibot bot added the master label Jun 10, 2022
@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.51 June 10, 2022 21:31
@civibot civibot bot added 5.51 and removed master labels Jun 10, 2022
Fixes dev/core#3421
Also see dev/core#3135
And the original cause: a6f2a80
@eileenmcnaughton eileenmcnaughton merged commit 08cf482 into civicrm:5.51 Jun 12, 2022
@eileenmcnaughton eileenmcnaughton deleted the dupeFixAgain branch June 12, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants