Deduepe - Fix form buttons (again) #23757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Yet another fix for the dedupe form buttons. This feels like a duplicate of the duplicate fix in #23035 but hopefully fixed for real this time and we can stop duplicating these duplicate button fixes!
Before
See dev/core#3421
Also see dev/core#3135
And the original cause: a6f2a80
After
With this patch in place I've tried out all the buttons in all the different contexts and they all seem to be behaving correctly:
Search Mode
Dedupe Find Mode
Technical Details
The problem is that the form is used in different contexts and it's a complex multi-step form, but it can also be used as a one-step form via search and it can also be loaded in an ajax modal. So getting the buttons to behave in every context is tricky.