dev/core#3675 Fix Permissioned Relationship pseudoconstant

[colemanw]

Overview

Fixes dev/core#3675 Permissioned Relationship no longer set up for "On Behalf of Organization" Membership Contribution Form submissions.

Replaces #23863

Before

Pseudoconstant callback used ambiguous flat array which caused several problems.

After

Unambiguous, works in every context.

Technical Details

See notes in #22730 for why this change is needed.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

This DOES fix it - but is it the ONLY one with the same issue? - or rather - is it one of two?

  public static function emailOnHoldOptions() {
    return [
      '0' => ts('No'),
      '1' => ts('On Hold Bounce'),
      '2' => ts('On Hold Opt Out'),
    ];
  }

[colemanw]

@eileenmcnaughton that other one would be trickier to convert because it's used all over the place:

The process of conversion when a callback function is getting called directly is typically to duplicate the function and rename the one being converted and update the name in the xml/DAO.

However, as I mentioned in https://github.com/civicrm/civicrm-core/pull/23863/files/6a76247c80ac66a15bf212a60dea7ca4e7aad5d4#r903460775 I think the fact that the array has a key of 0 is a red-herring. The pseudoconsant code should handle that correctly. The real change has to do with the fact that it no longer treats labels and names as interchangeable, as of #22730.

[eileenmcnaughton]

Ok - I'm still not convinced this won't hit us with other callback-pseudoconstant - but this IS the best fix for this specific pseudoconstant I think so merging