dev/core#3852 - Classload extension test folders during tests #24549
Conversation
|
(Standard links)
|
CRM/Extension/ClassLoader.php
Outdated
| @@ -164,6 +164,9 @@ private static function loadExtension(\Composer\Autoload\ClassLoader $loader, CR | |||
|
|
|||
| case 'psr4': | |||
| $loader->addPsr4($mapping['prefix'], $path . '/' . $mapping['path']); | |||
| if (defined('CIVICRM_TEST')) { | |||
| $loader->addPsr4($mapping['prefix'], $path . '/tests/phpunit/' . $mapping['path']); | |||
There was a problem hiding this comment.
@demeritcowboy just wondering if we should be testing for the presence of the test folder as well but probably doesn't matter that much
There was a problem hiding this comment.
Interesting question - yeah probably. Composer does this, so if the array is smaller to begin with it should be more efficient, trading one is_dir call here for several file_exists later. And then it would make sense to do it for non-test folders too.
Let's add it. For unscientific testing purposes the first one "Took 2 hr 31 min on test-1".
|
Latest run "Took 2 hr 37 min on test-1" - not a significant difference. |
|
Yeah it would surprise me - here we're talking about <10 extensions and about half DO have Civi-namespace tests anyway. |
Overview
https://lab.civicrm.org/dev/core/-/issues/3852
Before
Some extension actions like install fail if class scanning tries to scan them during tests.
After
Technical Details
Scanning runs more often after #24276, and the test folders weren't included in classloading.
Comments
I could include the unit test from the lab ticket, but it's a bit of a goofy test. Trying to think of something more likely to see in real life.
For what it's worth the drupal/mink tests now pass with this applied: e.g. https://github.com/SemperIT/CiviCARROT/actions/runs/3073761641/jobs/4966094386#step:19:4