Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Migrate JobLog page to API4
Before
The JobLog page was written in the traditional CiviCRM way using the DAO object. This led to notices on the JobLog screen from undefined array keys:
Given that up to 1000 rows are shown at the time this could lead to significant noise in the site logs.
After
The JobLog page now uses API4. API4 keys are always set (unlike DAO objects which didn't set properties for NULL values), meaning that no undefined array key warnings occur.
To faciltate this
JobLog
entitites are now exposed over the API.I have also done some minor tidy-up of the JobLog template:
$sj
variable was being set, but not referenced. Now removed.jobName
andjobRunUrl
are now always set, reducing reliance onempty
in the Smarty template (which I think is preferable when inCIVICRM_SMARTY_DEFAULT_ESCAPE
mode).Comments
I'm never quite sure how quickly PRs make it into a release, so the
@since 5.56
is a bit of a guess on the new API entity.I settled on
@searchable secondary
, but I think it's borderline whether this should besecondary
ornone
. I don't really mind either way.See also dev/core#2486