Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate single note view to API4, avoid PHP warnings #24609

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Sep 24, 2022

Overview

Migrate single note view to API4, avoid PHP warnings.

Before

When viewing a single contact note, multiple warnings could occur (depending on which note fields had been completed:

Screenshot 2022-09-24 at 13 57 48

After

Migrating to API4 and refactoring some of the logic removes the bulk of these warnings.

Comments

This doesn't address the warnings coming from contactFooter.tpl, which I can't work out why is being loaded. This also only addresses the single note view, not the browse notes or delete note templates.

@civibot
Copy link

civibot bot commented Sep 24, 2022

(Standard links)

@civibot civibot bot added the master label Sep 24, 2022
@seamuslee001
Copy link
Contributor

This looks right to me

@seamuslee001 seamuslee001 merged commit 793d7a3 into civicrm:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants