Migrate single note view to API4, avoid PHP warnings #24609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Migrate single note view to API4, avoid PHP warnings.
Before
When viewing a single contact note, multiple warnings could occur (depending on which note fields had been completed:
After
Migrating to API4 and refactoring some of the logic removes the bulk of these warnings.
Comments
This doesn't address the warnings coming from
contactFooter.tpl
, which I can't work out why is being loaded. This also only addresses the single note view, not the browse notes or delete note templates.